From 6f65a1c126ec1e66c968e6a2c783935a07de41af Mon Sep 17 00:00:00 2001 From: petitphp Date: Fri, 18 Feb 2022 19:04:37 +0100 Subject: [PATCH 1/3] Load translations for scripts in Gutenberg editor. --- src/ui/asset-manager.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/ui/asset-manager.php b/src/ui/asset-manager.php index 38e930b45..6c4cd8dbf 100644 --- a/src/ui/asset-manager.php +++ b/src/ui/asset-manager.php @@ -48,6 +48,9 @@ public function register_scripts() { \DUPLICATE_POST_CURRENT_VERSION, true ); + if ( function_exists( '\\wp_set_script_translations' ) ) { + \wp_set_script_translations( 'duplicate_post_edit_script', 'duplicate-post' ); + } \wp_register_script( 'duplicate_post_strings', @@ -60,6 +63,9 @@ public function register_scripts() { \DUPLICATE_POST_CURRENT_VERSION, true ); + if ( function_exists( '\\wp_set_script_translations' ) ) { + \wp_set_script_translations( 'duplicate_post_strings', 'duplicate-post' ); + } \wp_register_script( 'duplicate_post_quick_edit_script', From b9a5818ecbb08c9b1be9233feb2a6c4f6d44af23 Mon Sep 17 00:00:00 2001 From: petitphp Date: Fri, 18 Feb 2022 19:04:48 +0100 Subject: [PATCH 2/3] Update Asset_Manager tests with new call to wp_set_script_translations. --- tests/Unit/UI/Asset_Manager_Test.php | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tests/Unit/UI/Asset_Manager_Test.php b/tests/Unit/UI/Asset_Manager_Test.php index cf8869c0e..77a8e3652 100644 --- a/tests/Unit/UI/Asset_Manager_Test.php +++ b/tests/Unit/UI/Asset_Manager_Test.php @@ -114,6 +114,11 @@ public function test_register_scripts() { \DUPLICATE_POST_CURRENT_VERSION, true ); + Monkey\Functions\expect( '\wp_set_script_translations' ) + ->with( + 'duplicate_post_edit_script', + 'duplicate-post' + ); Monkey\Functions\expect( '\wp_register_script' ) ->with( @@ -127,6 +132,11 @@ public function test_register_scripts() { \DUPLICATE_POST_CURRENT_VERSION, true ); + Monkey\Functions\expect( '\wp_set_script_translations' ) + ->with( + 'duplicate_post_strings', + 'duplicate-post' + ); Monkey\Functions\expect( '\wp_register_script' ) ->with( From 9e816b2bd4ed71b86bd78a8b23b380cb4e87965a Mon Sep 17 00:00:00 2001 From: Enrico Battocchi Date: Fri, 15 Mar 2024 13:43:02 +0100 Subject: [PATCH 3/3] Remove `function_exists` since we don't support WP before 5.0 --- src/ui/asset-manager.php | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/ui/asset-manager.php b/src/ui/asset-manager.php index 6c4cd8dbf..8aa4965de 100644 --- a/src/ui/asset-manager.php +++ b/src/ui/asset-manager.php @@ -48,9 +48,7 @@ public function register_scripts() { \DUPLICATE_POST_CURRENT_VERSION, true ); - if ( function_exists( '\\wp_set_script_translations' ) ) { - \wp_set_script_translations( 'duplicate_post_edit_script', 'duplicate-post' ); - } + \wp_set_script_translations( 'duplicate_post_edit_script', 'duplicate-post' ); \wp_register_script( 'duplicate_post_strings', @@ -63,9 +61,7 @@ public function register_scripts() { \DUPLICATE_POST_CURRENT_VERSION, true ); - if ( function_exists( '\\wp_set_script_translations' ) ) { - \wp_set_script_translations( 'duplicate_post_strings', 'duplicate-post' ); - } + \wp_set_script_translations( 'duplicate_post_strings', 'duplicate-post' ); \wp_register_script( 'duplicate_post_quick_edit_script',