Skip to content
This repository has been archived by the owner on Apr 23, 2019. It is now read-only.

[Documentation] Limitation imposed by design #69

Open
stephanwlee opened this issue Dec 24, 2016 · 1 comment
Open

[Documentation] Limitation imposed by design #69

stephanwlee opened this issue Dec 24, 2016 · 1 comment

Comments

@stephanwlee
Copy link
Contributor

Mendel made some design choice that does not allow certain patterns. Document them.

@stephanwlee stephanwlee added this to the Mendel v2 milestone Dec 24, 2016
@irae
Copy link
Collaborator

irae commented Apr 16, 2017

One suggestion:

Invariant: Can't variate package.json runtime: If package.json exists on a variation, it should exist also on "base" and both should point at the same file/module and have the same "name". For instance, here are a list of invalid repo configurations:

$ find src/client -type f -name package\.json
./variations/foo/some-component/package.json
# Should throw, since base/foo//some-component/package.json don't exist on base/some-component/package.json

$ find src/client -type f -name package\.json
./base/some-component/package.json # → {"name": "foo"}
./variations/foo/some-component/package.json # → {"name": "bar"}
# Should throw because name mismatch on the same path.

$ find src/client -type f -name package\.json
./base/some-component/package.json # → {"main": "foo.js"}
./variations/foo/some-component/package.json # → {"main": "foo/index.js"}
# Should throw because path mismatch between variations

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants