Skip to content
This repository has been archived by the owner on Apr 23, 2019. It is now read-only.

JS File that only exists on variation should be picked up #145

Open
irae opened this issue Jan 30, 2018 · 0 comments
Open

JS File that only exists on variation should be picked up #145

irae opened this issue Jan 30, 2018 · 0 comments
Labels

Comments

@irae
Copy link
Collaborator

irae commented Jan 30, 2018

If my variation has a new require, Mendel is failing to pick it up right away. If I create a dummy file on my base variation, it starts working again.

How to reproduce in details:

If I have the following example:

    src/client
    ├── base
    │   └── actions
    │       └── activity.js
    └── variations
        └── new-card
            ├── activity-addon.js
            └── activity.js

Where:

  • base/actions/activity.js has no depencencies.
  • variations/new-card/activity.js has require('./activity-addon')

variations/new-card/activity-addon.js is never picked up on my variation and I get criptic errors, similar to what I would get if file didn't exists.

Workaround

Currently I am able to use Mendel by creating a dummy file

    src/client
    ├── base
    │   ├── activity-addon.js
    │   └── actions
    │       └── activity.js
    └── variations
        └── new-card
            ├── activity-addon.js
            └── activity.js

Where:

  • base/actions/activity.js has no depencencies.
  • base/actions/activity-addon.js is empty file
  • variations/new-card/activity.js has `require('./activity-addon')

variations/new-card/activity-addon.js now works.

@irae irae added the bug label Jan 30, 2018
@irae irae changed the title File that only exists on variation should be picked up JS File that only exists on variation should be picked up Aug 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant