Skip to content
This repository has been archived by the owner on Sep 21, 2018. It is now read-only.

Mail Server Issue #51

Open
nickwph opened this issue Mar 17, 2016 · 4 comments
Open

Mail Server Issue #51

nickwph opened this issue Mar 17, 2016 · 4 comments

Comments

@nickwph
Copy link
Contributor

nickwph commented Mar 17, 2016

Currently mailing service only works if it is configured in workers, not when it is configured in master.

Is it intended? @thekushpatel
Since in wiki, it is written that mailing service should be configured in master.

@nickwph nickwph changed the title Mail Server Mail Server Issue Mar 17, 2016
@thekushpatel
Copy link
Contributor

This looks like a bug, good catch.

I think the fix would be to change the documentation and the config.json.sample files so that the mailer is configured in the worker. Thoughts?

@nickwph
Copy link
Contributor Author

nickwph commented Mar 17, 2016

i mean, should it be configured in master or worker?
doing it in master may make more sense if guerilla only have 1 single mailing account.
but if we want to have multiple mailing account, would it make more sense to make it configurable in each job?

@BruceBGordon
Copy link
Contributor

I think it makes more sense for the mailer to be configured in the master. Allow an override in the job, but why burden the worker config with this? I want to maintain less.

@nickwph
Copy link
Contributor Author

nickwph commented Mar 21, 2016

let's do it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants