Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

400 Bad Request #95

Open
snaapbacker opened this issue Feb 5, 2021 · 11 comments
Open

400 Bad Request #95

snaapbacker opened this issue Feb 5, 2021 · 11 comments

Comments

@snaapbacker
Copy link

I have uploaded a theme with the order example. How do I specify the slug of the theme?
In the CSS it says text domain example and in the backend it recognizes version, theme and name of the theme.

@YahnisElsts
Copy link
Owner

You don't need to explicitly specify the slug. The update server will use the package file name without the ".zip" extension as the slug. For example, if the package is named example-theme.zip, the slug will be example-theme.

@snaapbacker
Copy link
Author

snaapbacker commented Feb 5, 2021

themius.zip called with this Just bad request.

At least it is indicated to me that an update is available. I was also able to activate the license. The update also worked.

@YahnisElsts
Copy link
Owner

Since you mentioned licenses, does that mean you have you customized the server? If so, make sure that the modified version/subclass that you're using still properly handles the slug query parameter. It looks like it's either being ignored or the server expects a different parameter name.

@snaapbacker
Copy link
Author

What do you mean by server customized? I have only translated the plugin.

@YahnisElsts
Copy link
Owner

wp-update-server doesn't have any built-in support for licenses. Since you mentioned that you were able to activate a license, I guessed that you might have customized the server to add some licensing features. Were you talking about something else?

I have only translated the plugin.

What do you mean by "the plugin"?

@snaapbacker
Copy link
Author

wp-update-server is a plugin for the update server. That's what I translated.

The license activation was in the test theme wich I treid to update with my update server.

@YahnisElsts
Copy link
Owner

I'm afraid I don't understand what you mean. wp-update-server is not a plugin. It's a stand-alone tool. Are you referring to some other plugin? Also, wp-update-server doesn't really have a user interface except a couple of error messages, so what did you translate? I looked at the link that you provided earlier and the error message was still in English.

The license activation was in the test theme [...]

What test theme is that? If I remember correctly, none of my test themes have anything related to license activation.

@nicoblg
Copy link

nicoblg commented May 6, 2021

Hi, i think i understood what snaapbacker means. Your tool was included in a discontinued wp-plugin-update-server from froger-me who uploaded it to Wordpress.org. Later on, Wordpress pulled the plugin reasoning for a TOS violation and froger-me abandoned the development of that said plugin leaving the repo online for whoever wants to implement/fix-it going forward.

It was really nice, inlcuding license mangament and dashboard ui for easy management of your packages and franky, i'm here to ask you if you would like to use that codebase to make your tool even better. Actually the plugin is stuck on v4p4 with obvious problems for GitHub remote access and it would be really great to see the two project merged.

@YahnisElsts
Copy link
Owner

Ah, that explains some things. Thank you for the information.

In principle, I'm all for extending and improving wp-update-server. It would be useful to have an actual web UI, and I had some ideas about GitHub API proxies to improve security (so you wouldn't have to give each user your access token). License management is more tricky because different developers prefer different licensing schemes and it's difficult to separate licensing from payment processing, but there are probably some viable options.

That said, my list of "things I should do" is already far longer than I can realistically manage, and this particular project is unfortunately not near the top. I'm not sure when, if ever, I might get around to this.

@nicoblg
Copy link

nicoblg commented May 6, 2021

As far as i can tell you, it should be fairly simple to merge your project with that but i understand that's something you want your time to investigate. That project seems to be half updated on your v4p9 but it seems to integrate it via your API, without touching your code.

License management is a complete different story.. Everyone wants it to be a little different, but the way it is implemented in that code it's fairly basic and should do the job for a lot of people, putting up the base for future work.

@YahnisElsts
Copy link
Owner

For my own future reference, this is the plugin being discussed above:
https://github.com/froger-me/wp-plugin-update-server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants