From ee0fa1a58c062b989113c3145f9b9a902c788fb7 Mon Sep 17 00:00:00 2001 From: Erika Hunhoff Date: Thu, 14 Nov 2024 15:43:22 -0700 Subject: [PATCH] Remove lingering npu_dma_memcpy_nd from alt examples --- .../basic/matrix_multiplication/cascade/aie2_alt.py | 13 ------------- .../matrix_multiplication/matrix_vector/aie2_alt.py | 9 --------- programming_examples/ml/eltwise_mul/aie2_alt.py | 5 ----- 3 files changed, 27 deletions(-) diff --git a/programming_examples/basic/matrix_multiplication/cascade/aie2_alt.py b/programming_examples/basic/matrix_multiplication/cascade/aie2_alt.py index 044f79573d..3a524e7fcf 100644 --- a/programming_examples/basic/matrix_multiplication/cascade/aie2_alt.py +++ b/programming_examples/basic/matrix_multiplication/cascade/aie2_alt.py @@ -385,19 +385,6 @@ def sequence(A, B, C): dma_start_task(a_task) in_tasks.append(a_task) - npu_dma_memcpy_nd( - metadata=B_l3l2_fifos[col], - bd_id=2 * tile_row + 2, - mem=B, - offsets=[0, 0, 0, B_col_offset], - sizes=[ - N // n // n_aie_cols, - K // k // n_aie_rows, - k * n_aie_rows, - n, - ], - strides=[n * n_aie_cols, k * n_aie_rows * N, N, 1], - ) b_task = dma_configure_task_for(B_l3l2_fifos[col]) with bds(b_task) as bd: with bd[0]: diff --git a/programming_examples/basic/matrix_multiplication/matrix_vector/aie2_alt.py b/programming_examples/basic/matrix_multiplication/matrix_vector/aie2_alt.py index ef7c12b071..d2ef580931 100644 --- a/programming_examples/basic/matrix_multiplication/matrix_vector/aie2_alt.py +++ b/programming_examples/basic/matrix_multiplication/matrix_vector/aie2_alt.py @@ -170,15 +170,6 @@ def sequence(A, B, C): dma_start_task(a_task) a_tasks.append(a_task) - npu_dma_memcpy_nd( - metadata=outC_fifos[i], - bd_id=0, - mem=C, - offsets=[0, 0, 0, C_offset], - sizes=[1, 1, 1, C_sz_div_n_cores], - strides=[0, 0, 0, 1], - ) - c_task = dma_configure_task_for(outC_fifos[i], issue_token=True) with bds(c_task) as bd: with bd[0]: diff --git a/programming_examples/ml/eltwise_mul/aie2_alt.py b/programming_examples/ml/eltwise_mul/aie2_alt.py index 260d7b76d3..6a01424107 100644 --- a/programming_examples/ml/eltwise_mul/aie2_alt.py +++ b/programming_examples/ml/eltwise_mul/aie2_alt.py @@ -143,11 +143,6 @@ def sequence(A, B, C): size=trace_size, offset=N_in_bytes, ) - npu_dma_memcpy_nd(metadata=inA, bd_id=1, mem=A, sizes=[1, 1, 1, N]) - npu_dma_memcpy_nd(metadata=inB, bd_id=2, mem=B, sizes=[1, 1, 1, N]) - npu_dma_memcpy_nd(metadata=outC, bd_id=0, mem=C, sizes=[1, 1, 1, N]) - # outC will only complete after inA and inB complete, so we just wait on outC instead of all - dma_wait(outC) in_a_task = dma_configure_task_for(inA) with bds(in_a_task) as bd: