Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ledger not found before ETL process has finished #1697

Open
ckniffen opened this issue Oct 19, 2024 · 0 comments
Open

Handle ledger not found before ETL process has finished #1697

ckniffen opened this issue Oct 19, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@ckniffen
Copy link

ckniffen commented Oct 19, 2024

Summary

Websocket events are currently proxied to the ETL source. When receiving a ledgerClosed event it is very common to request the new ledger to get all of its transaction details. Sometimes the ledger has not yet been processed by clio yet and lgrNotFound error is returned.

Solution

Solution 1

Do not proxy ledger closed events instead wait to emit them after the new ledger has been ingested and is available to retrieve.

Solution 2

Do not immediately return lgrNotFound if it is within some threshold of the most recently available ledger (maybe 1 or 2) and return once it is available. There could also be a reference to ledgers being ingested and it could be checked to see if the response should be delayed.

@ckniffen ckniffen added the enhancement New feature or request label Oct 19, 2024
@godexsoft godexsoft added this to the 2.4 milestone Oct 21, 2024
@kuznetsss kuznetsss modified the milestones: 2.4, 2.5 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants
@godexsoft @ckniffen @kuznetsss and others