Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated version of helm is used #56

Open
uthark opened this issue Feb 16, 2023 · 3 comments
Open

Outdated version of helm is used #56

uthark opened this issue Feb 16, 2023 · 3 comments

Comments

@uthark
Copy link

uthark commented Feb 16, 2023

Current version is 3.11.

Action uses helm 3.4.1

version.BuildInfo{Version:"v3.4.1", GitCommit:"c4e74854886b2efe3321e185578e6db9be0a6e29", GitTreeState:"clean", GoVersion:"go1.14.11"}

As a result, new helm options are not supported
(i.e helm lint --quiet fails).

ideally, add an option to set required helm/kubectl versions via action config to provide future proof support.

Other issues is that new helm chart for the cert-manager fails to be linted because old version of helm is used:

Error:  templates/cainjector-rbac.yaml: object name does not conform to Kubernetes naming requirements: "test-release-cert-manager-cainjector:leaderelection": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
Error:  templates/cainjector-rbac.yaml: object name does not conform to Kubernetes naming requirements: "test-release-cert-manager-cainjector:leaderelection": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
Error:  templates/rbac.yaml: object name does not conform to Kubernetes naming requirements: "test-release-cert-manager:leaderelection": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
Error:  templates/rbac.yaml: object name does not conform to Kubernetes naming requirements: "test-release-cert-manager:leaderelection": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
Error:  templates/rbac.yaml: object name does not conform to Kubernetes naming requirements: "test-release-cert-manager-controller-approve:cert-manager-io": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
Error:  templates/rbac.yaml: object name does not conform to Kubernetes naming requirements: "test-release-cert-manager-controller-approve:cert-manager-io": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
Error:  templates/startupapicheck-rbac.yaml: object name does not conform to Kubernetes naming requirements: "test-release-cert-manager-startupapicheck:create-cert": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
Error:  templates/startupapicheck-rbac.yaml: object name does not conform to Kubernetes naming requirements: "test-release-cert-manager-startupapicheck:create-cert": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
Error:  templates/webhook-rbac.yaml: object name does not conform to Kubernetes naming requirements: "test-release-cert-manager-webhook:dynamic-serving": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
Error:  templates/webhook-rbac.yaml: object name does not conform to Kubernetes naming requirements: "test-release-cert-manager-webhook:dynamic-serving": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
Error:  templates/webhook-rbac.yaml: object name does not conform to Kubernetes naming requirements: "test-release-cert-manager-webhook:subjectaccessreviews": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253
Error:  templates/webhook-rbac.yaml: object name does not conform to Kubernetes naming requirements: "test-release-cert-manager-webhook:subjectaccessreviews": invalid metadata name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 253

@WyriHaximus
Copy link
Owner

Hey @uthark working on getting v2.2 and v3 out tomorrow. v2.2 will bump the Helm version and v3 will turn this into a nodejs based action instead of a Docker one and make things like multi arch and using installed tooling on the runner easier.

@uthark
Copy link
Author

uthark commented Feb 20, 2023

Thanks. By the way, I tried the latest version from master on Thursday and got multiple "not found" errors.

@WyriHaximus
Copy link
Owner

Just released v3, which uses the latest version of helm. Yes I renamed masted to 3.x as I also was creating a 2.x as it's Docker based and the new v3 is nodejs based. I probably want to put a matser branch back with a warning 😅 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants