-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace System.err & System.out with proper logger API #15
Comments
It is OK to use System.err and System.out in main class such as SudachiCommandLine.java and PrintDictionaryHeader.java. But at least DictionaryBuilder.java should use logger interface. It seems that SLF4J is not so active recently, then I recommend to use Log4J 2. |
I expect to use DictionaryBuilder.java and UserDictionaryBuilder.java on the command line. Should I use a logger for them? |
Then not high priority I think. If I was you, I will introduce logger system eventually. It makes product easy to introduce |
Current implementation uses
System.out
andSystem.err
to output debug information, but it should be avoided in production code. Because using stdout and/or stderr directly makes system maintenance difficult, it doesn't support filtering base on log level nor class. It is also hard to apply log rotation and other log management mechanism.I cannot judge which logger API we should use, probably it is one of followings:
The text was updated successfully, but these errors were encountered: