Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Check if both CJS and ESM builds succeeded #876

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

adamziel
Copy link
Collaborator

@adamziel adamziel commented Dec 17, 2023

Adds the test:esmcjs check to GitHub CI, as it was missing.

Many Playground modules are built both to ES Modules for the browser and to CommonJS modules for Node.js. The test:esmcjs check runs after the build process and tries to both import and require the built modules in Node.js to confirm both forms can be used.

This PR also fixes a bug in that check to ensure both the import and require test scripts actually run.

Testing instructions

Confirm the CI build job is green and confirm the run included the test:esmcjs check.

Extracted from #851.

Adds the `test:esmcjs` check to GitHub CI, as it was missing.

Many Playground modules are built both to ES Modules for the
browser and to CommonJS modules for Node.js. The `test:esmcjs`
check runs after the build process and tries to both `import`
and `require` the built modules in Node.js to confirm both
forms can be used.

This PR also fixes a bug in that check to ensure both the
`import` and `require` test scripts actually run.

 ## Testing instructions

Confirm the CI build job is green and confirm the run included the
`test:esmcjs` check.
@adamziel adamziel added [Type] Enhancement New feature or request [Type] Repo / Project Management [Type] Reliability Playground uptime, reliability, not crashing labels Dec 17, 2023
@adamziel adamziel force-pushed the trunk branch 2 times, most recently from 680cd19 to 2e376d2 Compare October 4, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement New feature or request [Type] Reliability Playground uptime, reliability, not crashing [Type] Repo / Project Management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant