Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode not working for PV*SOL #366

Open
drajabr opened this issue Aug 11, 2024 · 3 comments
Open

Dark mode not working for PV*SOL #366

drajabr opened this issue Aug 11, 2024 · 3 comments

Comments

@drajabr
Copy link

drajabr commented Aug 11, 2024

Thanks for your efforts,
I use wintop for mainly setting dark mode for legacy applications. Please fix dark mode for PVSOL, you can download the trial version for 30 days for testing purposes.

Is it okay to create a bounty for this issue? as I'm not willing to pay to get it fixed asap.

Also, can we get dark mode memory?? I mean remember the apps switched dark mode on for, this would be so helpful.

@drajabr
Copy link
Author

drajabr commented Aug 11, 2024

Also, apps menus, popup windows, and pop-up prompts are not dark mode, can we get a fix for that too?

@gileli121
Copy link
Member

gileli121 commented Aug 18, 2024

Sorry for the late reply.
My efforts over the last months have focused on implementing an additional licensing method (in addition to the existing one) suitable for larger use cases. I will probably finish it by next weekend.

Is it okay to create a bounty for this issue? as I'm not willing to pay to get it fixed asap.

Yes, it is fine. I think that I will be able to find time for it. next week. contact me at [email protected]

Also, can we get dark mode memory?? I mean remember the apps switched dark mode on for, this would be so helpful.

This is supported already.
Enable dark-mode. While it is enabled, click on the save button:
image

Every time this window opens, it will auto-enable dark mode.
This feature is part of the paid plan (enabled if you use a license)

By the way, the last improvement was in the dark mode about the colors:
#362 (comment)

It was released in the pre-release of 5.23
You are welcome to share feedback :)

@drajabr
Copy link
Author

drajabr commented Aug 19, 2024

No worries, and no rush on this issue.

I found panzerdivisionbyzero/NegativeScreen-Process-Window-Edition for basic color inversion per window.
While it works well for that purpose, its dark mode isn't as refined as WindowTop's, also, I had to tweak it for better performance. A good thing with NegativeScreen is that its "legacy" inversion also applies to popups and extra windows from the same proccess, and possibly its color inversion matrix can be tweaked/optimized, which I might not get to do soon.

Since dark mode is my main focus, I'll be using NegativeScreen for now but appreciate your work on WindowTop.

Keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants