Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At least one CLIv2 command, if a typo exists, will time out and not report an error #780

Open
Peter-Moody opened this issue Sep 25, 2024 · 0 comments
Assignees

Comments

@Peter-Moody
Copy link

Peter-Moody commented Sep 25, 2024

Describe the bug
It appears that at least one CLIv2 command, when containing errors, is not reported to CLI by HCOM and the Concluded message is not being sent. My guess is that oversights in the recent changes to HCOM, in which subdirectory support was added, is the cause.

To Reproduce

  1. Use CLIv2 to download a file to subdirectory e.g. meadow file write -f C:\HcomFiles\Write\Text\TestFile2k.txt -t /meadow0/dir1x/TestFile2k-1.txt
  2. Use CLIv2 to attempt list the file e.g. meadow file list /meadow/dir2x/ <- Notice a typo /meadow/ should be /meadow0/
  3. The above CLIv2 command will eventually timeout. However, if you are viewing syslog output there is a obvious error reported.
Getting file list from '/meadow/dir2x/'...
The operation has timed out.

From syslog
[ 64.261000] [ 8] (Error) file/hcom_file_dir_mgmt_utils.c@325-pathname '/meadow/dir2x/' is invalid
4. It appears that HCOM is not sending this error to CLI and not sending the Concluded message either.

Expected behavior
CLI should show the error and return immediately.

Meadow (please complete the following information as best as you can):
Meadow by Wilderness Labs
Board Information
Model: F7Micro
Hardware version: F7FeatherV2
Device name: MeadowF7

Hardware Information
Processor type: STM32F777IIK6
ID: 34-00-19-00-09-50-30-52-54-31-35-20
Serial number: 204E31925230
Coprocessor type: ESP32

Firmware Versions
OS: 1.14.1.7
Runtime: 1.14.1.7
Coprocessor:
Protocol: 8

@Peter-Moody Peter-Moody changed the title CLIv2 commands e.g. meadow file list /meadow/dir2x/ which as a typo, CLI eventually times out CLIv2 at least one CLI command if a typo exists will eventually time out and not report an error Sep 25, 2024
@Peter-Moody Peter-Moody changed the title CLIv2 at least one CLI command if a typo exists will eventually time out and not report an error At least one CLIv2 command, if a typo exists, will time out and not report an error Sep 25, 2024
@alexischr alexischr added p2 p1 and removed p2 labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants