Strip probited initial character in Glossary CSV upload #12806
+125
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ial_character_in_csv_element
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12806 +/- ##
=======================================
Coverage 91.17% 91.18%
=======================================
Files 596 597 +1
Lines 61151 61201 +50
Branches 6345 6347 +2
=======================================
+ Hits 55755 55804 +49
Misses 3745 3745
- Partials 1651 1652 +1
|
…ial_character_in_csv_element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problematic initial characters are stripped from glossary terms before upload . Prohibited characters are:
{"=", "+", "-", "@", "|", "%"}I chose this option over excluding the terms altogether
Checklist
Other information
fixes #12792