Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for revoked credential for holder #188

Closed

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Jan 6, 2024

First attempt to add coverage to resolve #187

Created as draft because it does not work at the moment. What are the intended steps here? Another IPEX grant + admit after revocation?

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b20807) 81.42% compared to head (27f8411) 81.42%.
Report is 22 commits behind head on development.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #188   +/-   ##
============================================
  Coverage        81.42%   81.42%           
============================================
  Files               46       46           
  Lines             4141     4141           
  Branches          1030     1030           
============================================
  Hits              3372     3372           
  Misses             737      737           
  Partials            32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pfeairheller
Copy link
Member

Close this PR as it is over a month old. Let's discuss the steps for revocation at the developer's meeting on Thursday

@lenkan lenkan deleted the 187-fix-revoked-credential-check branch April 13, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing integration test coverage for holding revoked credential
3 participants