Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put plotting into an extension ? #5

Open
j-fu opened this issue Oct 30, 2024 · 6 comments
Open

Put plotting into an extension ? #5

j-fu opened this issue Oct 30, 2024 · 6 comments

Comments

@j-fu
Copy link
Member

j-fu commented Oct 30, 2024

This would remove UnicodePlots as a strong dependency and remove some compilation time for users.

@chmerdon
Copy link
Member

Yes, that's a good idea. Will do this.

@chmerdon
Copy link
Member

chmerdon commented Oct 31, 2024

Ok, I am running into a subtle issue:

  • for the plots I require UnicodePlots and Term

When I do

[weakdeps]
UnicodePlots = "b8865327-cd53-5732-bb35-84acbb429228"
Term = "22787eb5-b846-44ae-b979-8e399b8463ab"

[extensions]
ExtendableFEMBaseUnicodePlotsExt = "UnicodePlots"

Term is not found during compilation of the extension. How can I make Term another dependency of the extension?
(If I move Term back to the main dependencies I get a stale dependency error from Aqua.)

@j-fu
Copy link
Member Author

j-fu commented Oct 31, 2024

Ah need to think about this. Need to think about this.
May be related to JuliaLang/julia#56368 ?

@chmerdon
Copy link
Member

Ok, it works in principle with

ExtendableFEMBaseUnicodePlotsExt = ["UnicodePlots", "Term"]

but then the user needs to use both packages to trigger that the extension is loaded. It would be more convenient that only UnicodePlots needs to be used...

@chmerdon
Copy link
Member

chmerdon commented Oct 31, 2024

Term triggers an extension in UnicodePlots by the way from which I use a function for the scalarplot. But maybe I should try to find some workaround...

@chmerdon
Copy link
Member

Ok, for now I have switched off the line that requires Term. The extension seems to work now and only requires UnicodePlots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants