-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure with fmt 11 #4700
Labels
Bug
Bug in learning semantics, critical by default
Comments
It looks like this isn't passing the CI checks: https://github.com/VowpalWabbit/vowpal_wabbit/actions/runs/11389180985/job/31687872013?pr=4702 . Do you know what the variance in your build environment is? |
That job is targeting WASM, which seems like an important difference. The Linux and macOS builds at #4702 seem to work fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The build fails with fmt 11+.
I don't have the error log anymore, but I can reproduce it if required. A patch is attached below.
How to reproduce
Build vowpal_wabbit with fmt 11+.
Version
9.10.0
OS
macOS
Language
C++
Additional context
This patch seems to fix things:
Patch
The text was updated successfully, but these errors were encountered: