Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose commit hash from pyvw metadata #4185

Open
ataymano opened this issue Oct 5, 2022 · 4 comments
Open

Expose commit hash from pyvw metadata #4185

ataymano opened this issue Oct 5, 2022 · 4 comments
Labels
Feature Request New feature requested in system

Comments

@ataymano
Copy link
Member

ataymano commented Oct 5, 2022

Short description

Please expose git commit to pyvw version number if it is possible.
cmd:

vw --version
9.2.0 (git commit: 1be36baae)

python:

>>> vowpalwabbit.__version__
'9.1.0'

How this suggestion will help you/others

Consistent versioning across c++ and python is good in general. It will also help to improve vw_executor and support vw versioning there.

@ataymano ataymano added the Feature Request New feature requested in system label Oct 5, 2022
@jackgerrits
Copy link
Member

I think that value is meant to stay a standard semver value. But there is nothing stopping us adding commit which exposes the commit

@lalo
Copy link
Collaborator

lalo commented Oct 6, 2022

#3446

@ataymano
Copy link
Member Author

ataymano commented Oct 9, 2022

#3446

Thank you!

@ataymano ataymano closed this as completed Oct 9, 2022
@lalo lalo reopened this Oct 17, 2022
@lalo
Copy link
Collaborator

lalo commented Oct 17, 2022

Re-opening since that PR is just a breadcrumb from a previous approach we did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature requested in system
Projects
None yet
Development

No branches or pull requests

3 participants