Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create VCPKG package for VowpalWabbit #2228

Closed
jackgerrits opened this issue Jan 17, 2020 · 8 comments · Fixed by microsoft/vcpkg#27323
Closed

Create VCPKG package for VowpalWabbit #2228

jackgerrits opened this issue Jan 17, 2020 · 8 comments · Fixed by microsoft/vcpkg#27323
Labels
Distribution Issue Issue around distribution of binary packages Feature Request New feature requested in system Help wanted PRs welcome

Comments

@jackgerrits
Copy link
Member

Vcpkg is a C++ dependency management system that makes installation and consumption as a dependency very easy. We should support this for VW to allow consuming the lib as easy as possible.

Instructions for creating a new package can be found here: https://github.com/microsoft/vcpkg/blob/master/docs/examples/packaging-github-repos.md

@jackgerrits jackgerrits added Feature Request New feature requested in system Help wanted PRs welcome Good First Issue labels Jan 17, 2020
@bhavukkalra
Copy link

hello @jackgerrits I would love to work on this as a first issue. Could you please guide me to what particular C++ files to package with it. I am having trouble finding them in the repo.
It would be great to get a head start.

@jackgerrits
Copy link
Member Author

I had a first crack at this a few weeks ago and this issue is actually blocked on symbol export issues we noticed in #2235. Before we can reasonably create a VCPKG package all of the internal libs need to properly export symbols for when they are built as dynamic libs.

@dnabanita7
Copy link

@jackgerrits I am a beginner and want to contribute to Vowpal Wabbit. Is the symbol export issue resolved?

@jackgerrits
Copy link
Member Author

I am not sure if that issue is properly resolved. I'd say we are not likely in a good enough spot for this yet. But if you'd like to hack on it please feel free.

@dnabanita7
Copy link

I will first try the previous issue then hop into symbol export issue.

@jackgerrits jackgerrits added the Distribution Issue Issue around distribution of binary packages label Dec 3, 2021
@ras0219-msft
Copy link

To help move this issue forward: it isn't a requirement to support building as a DLL on Windows to be packaged into vcpkg. The recipe can simply add the following to the top to indicate it must be built as a static library:

vcpkg_check_linkage(ONLY_STATIC_LIBRARY)

@jackgerrits
Copy link
Member Author

Thanks for the info @ras0219-msft! I had noticed that one a couple of months ago and was excited to learn it is possible. Haven't had a chance to get around to this issue and it hasn't made it to the top of the backlog. Definitely still hope to get to it

@jackgerrits
Copy link
Member Author

The vowpal-wabbit port was merged in microsoft/vcpkg#27323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Distribution Issue Issue around distribution of binary packages Feature Request New feature requested in system Help wanted PRs welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants