Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_cli_driver ignores SIGINT #77

Open
mwydmuch opened this issue Mar 29, 2023 · 1 comment
Open

run_cli_driver ignores SIGINT #77

mwydmuch opened this issue Mar 29, 2023 · 1 comment

Comments

@mwydmuch
Copy link

As in the title, run_cli_driver method ignores SIGINT send to the python script and waits till the end of the run.
This is probably also the case for other methods, but this one usually takes a lot of time.

Example:

  1. Run the script from Prediction memory error with new PLT --probabilities option vowpal_wabbit#4510 (comment)
  2. Press Ctrl+C/Cmd+C after a few seconds
  3. The script will finish the run of cli driver before interrupting.
@jackgerrits
Copy link
Member

I opened #78 to partially address this issue, however, it is currently only able to early exit when the next pass completes. The early exit logic in VW is centered around passes which is the reason for this limitation. I opened a feature request in VW (VowpalWabbit/vowpal_wabbit#4540) to properly handle early exit for the middle of a pass, which could have nice side effects of handling SIGINT in a better way in the core tool too.

jackgerrits added a commit that referenced this issue Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants