Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asking about versions that meet OJS 3.2.2 November 2020 #126

Open
ainulrafiq opened this issue Jan 5, 2021 · 11 comments
Open

Asking about versions that meet OJS 3.2.2 November 2020 #126

ainulrafiq opened this issue Jan 5, 2021 · 11 comments

Comments

@ainulrafiq
Copy link

Dear themes team,
We are using OJS 3.2.2 November built and trying to apply the oldGregg theme into it. But the result is not satisfying yet. Here is the issue sample https://myjurnal.poltekkes-kdi.ac.id/index.php/jippm/article/view/241, the XML galley doesn't appear. Is there any version of the theme that works with the ojs Version?

Thanks

@Vitaliy-1
Copy link
Owner

The latest OJS version is 3.2.1-1 and the theme version 2.1.0 is compatible with it. Are there any errors in PHP error log that appear after trying to access the article landing page?

@ainulrafiq
Copy link
Author

We are using OJS version 3.2.1.2 and the theme version 2.1.0. Here is the detail from error_log

[06-Jan-2021 02:48:33 UTC] PHP Warning: call_user_func_array() expects parameter 1 to be a valid callback, class 'PKPComponentRouter' does not have a method 'getRequestedPage' in /home/adeputra23/public_html/myjurnal/lib/pkp/classes/core/PKPRequest.inc.php on line 760
[06-Jan-2021 02:48:33 UTC] PHP Stack trace:
[06-Jan-2021 02:48:33 UTC] PHP 1. {main}() /home/adeputra23/public_html/myjurnal/index.php:0
[06-Jan-2021 02:48:33 UTC] PHP 2. Application->execute() /home/adeputra23/public_html/myjurnal/index.php:68
[06-Jan-2021 02:48:33 UTC] PHP 3. Dispatcher->dispatch() /home/adeputra23/public_html/myjurnal/lib/pkp/classes/core/PKPApplication.inc.php:281
[06-Jan-2021 02:48:33 UTC] PHP 4. PluginRegistry::loadCategory() /home/adeputra23/public_html/myjurnal/lib/pkp/classes/core/Dispatcher.inc.php:132
[06-Jan-2021 02:48:33 UTC] PHP 5. PluginRegistry::register() /home/adeputra23/public_html/myjurnal/lib/pkp/classes/plugins/PluginRegistry.inc.php:144
[06-Jan-2021 02:48:33 UTC] PHP 6. CustomBlockManagerPlugin->register() /home/adeputra23/public_html/myjurnal/lib/pkp/classes/plugins/PluginRegistry.inc.php:69
[06-Jan-2021 02:48:33 UTC] PHP 7. CustomBlockManagerPlugin->register() /home/adeputra23/public_html/myjurnal/plugins/generic/customBlockManager/CustomBlockManagerPlugin.inc.php:38
[06-Jan-2021 02:48:33 UTC] PHP 8. CustomBlockManagerPlugin->register() /home/adeputra23/public_html/myjurnal/lib/pkp/classes/plugins/LazyLoadPlugin.inc.php:28
[06-Jan-2021 02:48:33 UTC] PHP 9. CustomBlockManagerPlugin->_registerTemplateResource() /home/adeputra23/public_html/myjurnal/lib/pkp/classes/plugins/Plugin.inc.php:118
[06-Jan-2021 02:48:33 UTC] PHP 10. PKPTemplateManager::getManager() /home/adeputra23/public_html/myjurnal/lib/pkp/classes/plugins/Plugin.inc.php:368
[06-Jan-2021 02:48:33 UTC] PHP 11. PluginRegistry::loadCategory() /home/adeputra23/public_html/myjurnal/lib/pkp/classes/template/PKPTemplateManager.inc.php:983
[06-Jan-2021 02:48:33 UTC] PHP 12. HookRegistry::call() /home/adeputra23/public_html/myjurnal/lib/pkp/classes/plugins/PluginRegistry.inc.php:154
[06-Jan-2021 02:48:33 UTC] PHP 13. OldGreggThemePlugin->themeRegistered() /home/adeputra23/public_html/myjurnal/lib/pkp/classes/plugins/HookRegistry.inc.php:107
[06-Jan-2021 02:48:33 UTC] PHP 14. OldGreggThemePlugin->init() /home/adeputra23/public_html/myjurnal/lib/pkp/classes/plugins/ThemePlugin.inc.php:106
[06-Jan-2021 02:48:33 UTC] PHP 15. Request->getRequestedPage() /home/adeputra23/public_html/myjurnal/plugins/themes/oldGregg/OldGreggThemePlugin.inc.php:71
[06-Jan-2021 02:48:33 UTC] PHP 16. Request->_delegateToRouter() /home/adeputra23/public_html/myjurnal/lib/pkp/classes/core/PKPRequest.inc.php:690

thank you

@Vitaliy-1
Copy link
Owner

@ainulrafiq, can you test the referenced commit? For some reason, I'm not able to reproduce that error.

@ainulrafiq
Copy link
Author

Dear @Vitaliy-1 , I've implemented the referenced commit above, but there is no change https://myjurnal.poltekkes-kdi.ac.id/index.php/jippm/article/view/241 .

Thank you!

@Vitaliy-1
Copy link
Owner

@ainulrafiq,

If you implemented the modification, error message should definitely change, how it looks like now?

@ainulrafiq
Copy link
Author

ainulrafiq commented Jan 8, 2021

Dear @Vitaliy-1 , only these that apper on the error_log

[08-Jan-2021 06:23:27 UTC] PHP Deprecated: Non-static method PKPApplication::getRequest() should not be called statically in /home/adeputra23/public_html/myjurnal/plugins/generic/reviewerCredits/ReviewerCredits.inc.php on line 227
[08-Jan-2021 06:23:27 UTC] PHP Stack trace:
[08-Jan-2021 06:23:27 UTC] PHP 1. {main}() /home/adeputra23/public_html/myjurnal/index.php:0
[08-Jan-2021 06:23:27 UTC] PHP 2. Application->execute() /home/adeputra23/public_html/myjurnal/index.php:68
[08-Jan-2021 06:23:27 UTC] PHP 3. Dispatcher->dispatch() /home/adeputra23/public_html/myjurnal/lib/pkp/classes/core/PKPApplication.inc.php:281
[08-Jan-2021 06:23:27 UTC] PHP 4. PKPComponentRouter->route() /home/adeputra23/public_html/myjurnal/lib/pkp/classes/core/Dispatcher.inc.php:143
[08-Jan-2021 06:23:27 UTC] PHP 5. PKPComponentRouter->_authorizeInitializeAndCallRequest() /home/adeputra2

Thanks

@Vitaliy-1
Copy link
Owner

@ainulrafiq, this message looks truncated, can you post the full one, like the previous.

@ainulrafiq
Copy link
Author

I've updated the details, @Vitaliy-1

@Vitaliy-1
Copy link
Owner

it's only a cosmetic warning, is there anything else in the log?

@ainulrafiq
Copy link
Author

ainulrafiq commented Jan 8, 2021 via email

@Vitaliy-1
Copy link
Owner

@ainulrafiq, hmm, I don't understand. Does the issue appear? Can you double-check by visiting the page and looking at the log just after reproducing the error.
I can't reproduce the problem, our production instance that uses the latest checkout from the master branch works as expected: https://uk.e-medjournal.com/index.php/psp/article/view/258.
I need some more details here to make a fix, either an error message or steps to reproduce the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants