Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way of passing all models as array #49

Closed
e200 opened this issue May 29, 2018 · 9 comments
Closed

A way of passing all models as array #49

e200 opened this issue May 29, 2018 · 9 comments

Comments

@e200
Copy link

e200 commented May 29, 2018

Is there a way we can pass an array containing all models instead of adding one by one using method chain????

@koskimas
Copy link
Collaborator

No

@e200
Copy link
Author

e200 commented May 30, 2018

Any plans to add it?

@timhuff
Copy link
Collaborator

timhuff commented Jun 16, 2018

@koskimas I have a pull request open for this feature (submitted Feb 15th). Seems a reasonable API to have. Any reason why it hasn't been accepted? I also have two other pull requests open that I feel improve the usability of the library. I have the equivalent of this one for subscriptions on my fork but haven't bothered opening a pull request for it. Same story with this feature. I'd like to encourage the growth of this library, as I feel it's a great tool, it's been very beneficial to my work, and I see a lot of potential in it but it seems I might be wasting my time at this point.

edit: Upon re-reading, seems this could come off as whiney. I didn't write it with that tone. I was sincerely asking if there's a reason (e.g. not agreeing with the feature, implementation, etc) or if they've simply not been addressed due to a lack of manpower.

@koskimas
Copy link
Collaborator

@timhuff I haven't worked on this library in a while now. I can give you direct write access. I closed this issue as a reaction to the four question marks 😄 I'll add you as soon as github lets me (I wrote the wrong password too many times and cannot log in currently)

@timhuff
Copy link
Collaborator

timhuff commented Jun 16, 2018

@koskimas That'd be great! Thanks! Out of curiosity, what caused you to stop your work on it? Did you stop using objection and/or graphql? Or did you find that the approach wasn't flexible enough for your needs?

@koskimas
Copy link
Collaborator

@timhuff Do you have an npm account? I could add you there too so that you can make releases

@timhuff
Copy link
Collaborator

timhuff commented Jun 16, 2018

Yea, it's the same. timhuff.

@timhuff
Copy link
Collaborator

timhuff commented Jun 16, 2018

Thanks again. I'm really looking forward to working on it.

@koskimas
Copy link
Collaborator

@timhuff Done. To answer your earlier question, I just never ended up using graphql in any project. Also objection eats up most of my OSS time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants