Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a proper unparse method for DiffTrees #70

Open
ibbem opened this issue Mar 3, 2023 · 2 comments
Open

Implement a proper unparse method for DiffTrees #70

ibbem opened this issue Mar 3, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@ibbem
Copy link
Collaborator

ibbem commented Mar 3, 2023

The old DiffTree.toTextDiff has been removed in #67 because it wasn't able to serialize DiffTrees with moved subtrees. We need a replacement that is able to cope with all DiffTrees properly.

In contrast to line graphs the resulting format should be human readable (e.g. for use in debug messages) and ideally injective to be used in test assertions.
@ibbem ibbem mentioned this issue Mar 3, 2023
Closed
@pmbittner
Copy link
Member

@AlexanderSchultheiss You currently have an own implementation for unparsing in VEVOS right? Can you give us a pointer to where it is? Can we reuse it in DiffDetective?

@pmbittner pmbittner added the enhancement New feature or request label Sep 28, 2023
@AlexanderSchultheiss
Copy link
Member

I have not really implemented an unparse procedure yet. I only translate DiffTrees to the ground truth format of KernelHaven.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pmbittner @AlexanderSchultheiss @ibbem