Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent code formatting #136

Open
ibbem opened this issue Mar 4, 2024 · 0 comments
Open

Consistent code formatting #136

ibbem opened this issue Mar 4, 2024 · 0 comments

Comments

@ibbem
Copy link
Collaborator

ibbem commented Mar 4, 2024

Which code formatter should we use, without forcing developers into using a specific IDE?

@pmbittner is using Intellij with its default settings, right?
@AlexanderSchultheiss and I are using jdtls with its default settings.
Some code is committed without going through a code formatter.

Both are quite configurable. It seems like the settings of Intellij can be exported as a jdtls settings file called Eclipse profile. @pmbittner could you export your formatting settings, then I will check how different Intellij's and jdtls' formatters handle these settings. If there are no differences we can just commit both setting files into the repo and all current developers should be happy.
If they differ too much we should decide on one formatter which can be integrated into the different IDEs.

What do you think about a precommit hook or CI for code formatting to ensure the code is/stays consistent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant