Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Icons and Broken procedures on non gnome custom image. #346

Open
Maxwelldoug opened this issue Oct 16, 2024 · 13 comments
Open

Missing Icons and Broken procedures on non gnome custom image. #346

Maxwelldoug opened this issue Oct 16, 2024 · 13 comments

Comments

@Maxwelldoug
Copy link

Hey folks! I'm the primary maintainer of the Kanola Project. I am attempting to implement non gnome images in the VanillaOS framework, starting with KDE plasma. In my architecture, I use 2 build stages, an underlying "Base" image about halfway between core and desktop, containing all of the parts of the desktop image that are not necessarily tied to a specific DE, such as the first boot installer here followed by a second set of DE specific patches, which for Kanola (plasma) live here

The issues start on effectively the first page. I have been told that I need adwaita-icon-theme to provide the icons for the installer, but as pictured, they still do not render despite the aforementioned package and adwaita-icon-theme-full being present.

image

Secondly, the implementation of the "Finished!" page and the "Reboot Now" button:
image
Do not work. Based on my quick research, this button runs a gnome-specific program to reboot the machine. This should probably be changed to a more generic method using xdg or even the raw /usr/sbin/reboot. However, if this is out of scope, I should be able to fix this in the recipe on my end.

However, the third issue is by far the biggest. On a manual reboot, after working around an issue with Plasma not supporting forced password changes (and needing to go into a TTY to set my password) which is not your fault, I log in for the final step. However, instead of installing 40 some odd flatpaks, I instead get the following error spammed dozens of times, followed by userdel failing to remove the vanilla user and everything goes pear-shaped. This leaves me with a mostly usable but rather dysfunctional system, having leftover setup users and effectively no default apps.
image

This is proving a major roadblock in implementing Plasma, as currently for any new user to install it they must complete a full install on the official images and then rebase into Plasma to make their user accounts and default apps load correctly. Any support you guys can give here would be much appreciated. I am sure this is just as much my fault as anyone else's, but me and my fellows are running out of ideas as to what could be causing these issues.

@Maxwelldoug Maxwelldoug changed the title Missing Icons and Broken procedures on non plasma custom image. Missing Icons and Broken procedures on non gnomecustom image. Oct 16, 2024
@Maxwelldoug Maxwelldoug changed the title Missing Icons and Broken procedures on non gnomecustom image. Missing Icons and Broken procedures on non gnome custom image. Oct 16, 2024
@jardon
Copy link
Member

jardon commented Oct 18, 2024

A KDE spin sounds awesome! Let me see if I can answer your questions adequately:

  1. this is a failure on dependency management of the package. I'm trying to figure out exactly what package it needs. on base vanilla, this package is included by another package, but this should be added to the first-setup packaging as a dependency. I'll keep looking, but I you figure it out before I do, feel free to let me know!

  2. yes, it uses gnome-session-quit. i agree with you that it would be better if it was more DE agnostic. any specific ideas here?

  3. I need a little more context here. where is this output from?

i'd suggest putting in a separate bug report for 2 and 3 and include specific steps to reproduce :)

@jardon
Copy link
Member

jardon commented Oct 18, 2024

maybe try the gnome-icon-theme package?

@Maxwelldoug
Copy link
Author

Maxwelldoug commented Oct 18, 2024

  • I will see if gnome-icon-theme resolves these issues, likely tomorrow as I'm working late today.
  • Simply calling /usr/sbin/reboot would almost certainly do the job where you are currently using gnome-session, but there may be a more DE friendly route I am simply forgetting.
  • The third screenshot is from the box that appears after logging into the new user after reboot. On a default installation, flatpak apps and vso are installed here, but It occurs 9 times out of 10 using custom image to install Kanola, so it should be trivial to reproduce. To reproduce, do the following.

  • With the Vanilla installer, select custom image, and proceed as normal with the image url as ghcr.io/kanola-images/plasma:main (or ghcr.io/kanola-images/nplasma:main if you require nvidia drivers.)
  • reboot
  • login to the vanilla user with the password 'vanilla' and procede as normal, selecting your desired apps.
  • reboot again, this time using the plasma shell as the reboot button does not work for reasons pre-described.
  • hit ctrl+alt+f3, and use the username you set previously to login, and set your password, then exit that session. This works around an issue with SDDM simply failing if a forced password change is in place.
  • ctrl+alt+f2 and select the correct user to login to on SDDM.
  • See the error spam occur instead of your flatpaks installing.

@jardon
Copy link
Member

jardon commented Oct 18, 2024

i can more or less reproduce your error. ive been looking at the logging for first setup so that it is more beneficial for us

@jardon
Copy link
Member

jardon commented Oct 20, 2024

Can you confirm if gnome-icon-theme worked?

@Maxwelldoug

@Maxwelldoug
Copy link
Author

Hey, sorry for the delay, I've had quite a day. It's 10 o'clock here and I'm stopping to breathe for the first time since I woke up about 14 hours ago. I've just started the build on Base, and once that's done, I'll queue up Kanola and finally break for dinner. Will update once that's compiled and I'm not 28 hours since I last ate.

@Maxwelldoug
Copy link
Author

2 Hours later. 10 tries in, installer refuses to continue past partitioning (this is a long standing issue that nobody seems able to fix) and I'm done fighting with it at half past midnight. I've got several hours of driving tomorrow so I can make no promises as to how long it will be before I get another chance. If you so desire, you are free to test yourself while you wait on the caveat that you will need to use plasma:dev as I have not pulled the change to main and the nvidia image does not have a dev branch.

Hopefully I can get to it soon, and sorry for the delay.

@jardon
Copy link
Member

jardon commented Oct 20, 2024

No need to apologize! I was only checking back in based on the estimate. I'll see if I can swing checking that, but if I havent commented back then I probably havent gotten around to it.

@jardon
Copy link
Member

jardon commented Oct 20, 2024

also, is the installer bug documented somewhere?

@Maxwelldoug
Copy link
Author

Vanilla-OS/Albius#74

@jardon
Copy link
Member

jardon commented Oct 20, 2024

looks like gnome-icon-theme did not fix the issue. i'll keep looking into it

@Maxwelldoug
Copy link
Author

Can confirm, issue not resolved by that package.

@jardon
Copy link
Member

jardon commented Oct 21, 2024

Those svgs are included in adwaita-icon-theme but it seems to not be all we need here. I have a couple ideas. I'll see what I can figure out tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants