Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software is non-free because of libbass #3

Open
Profpatsch opened this issue Jun 11, 2017 · 6 comments
Open

Software is non-free because of libbass #3

Profpatsch opened this issue Jun 11, 2017 · 6 comments

Comments

@Profpatsch
Copy link

Profpatsch commented Jun 11, 2017

I’m packaging the software for NixOS, and unfortunately one has to enable non-free packages because the dependency libbass is a non-free package.
So calling Creator a free and open source project is only superficially true; it could never be included in completely free distributions like Trisquel, GuixSD, &c.

I don’t know how much functionality depends on libbass and how much work it would be, but there probably are free libraries supporting the use case of Creator.

@bohning
Copy link
Collaborator

bohning commented Jun 13, 2017

Unfortunately, it is not as easy to get rid of bass(_fx) in UltraStar-Creator as it is also used to determine the song's BPM. If anybody can suggest an open source library to determine the BPM of a given audio file, I'd be happy to work on replacing bass...

@basisbit
Copy link
Member

you could try https://github.com/basisbit/bpm-tools

@bohning
Copy link
Collaborator

bohning commented Jun 13, 2017

@enetheru
Copy link

enetheru commented Oct 7, 2017

I'm interested in helping with this effort in any way that I can, as I use arch and the libbass distributed simply does not work for my target platform.

If there is someone who can mentor me through it I'm sure I can get things moving.

EDIT: Didn't notice the bass removed branch.

@bohning
Copy link
Collaborator

bohning commented Oct 10, 2017

@enetheru I already have a development branch for this here. It now uses Qt Multimedia for all playback tasks. Only open issue: BPM detection of the MP3 source. This is not feasible with Qt Multimedia, so another open source library needs to be used for this. I looked into aubio and made some first steps, but aubio in turn depends on FFMPEG for decoding MP3 files, so for Windows, all FFMPEG libraries need to be shipped with UltraStar Creator... If you can find a good solution for BPM detection, that would be of great help.

EDIT: Just noticed your edit that you found the bass_removed branch after my comment...

@enetheru
Copy link

A very simple and quick solution that can sometimes be more accurate is to have the user tap it out with a button and take the rolling average. i find this far more reliable on some of my salsa music than automatic beat detection. But i haven't forgotten about this project i was just working on other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants