Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] Move letter grade math to calculateGrades func #294

Open
TyHil opened this issue Oct 30, 2024 · 0 comments
Open

[Internal] Move letter grade math to calculateGrades func #294

TyHil opened this issue Oct 30, 2024 · 0 comments
Labels
Good First Issue Good for newcomers Type: Internal Chore tasks that are needed for other features

Comments

@TyHil
Copy link
Member

TyHil commented Oct 30, 2024

Overview of Proposed Changes

Instead of recalculating the letter grade based on the GPA in the searchResultsTable component, store this data like the gpa is stored in calculateGrades.

Details

Changes are needed in and searchResultsTable the dashboard

Reference Skedge for an example:
https://github.com/UTDNebula/skedge/blob/bd999e5ea43893e600aef44f6110e62a0a79796c/src/pages/index.tsx#L86-L93
@TyHil TyHil added Type: Internal Chore tasks that are needed for other features Good First Issue Good for newcomers labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for newcomers Type: Internal Chore tasks that are needed for other features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TyHil