Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: LHS & RHS handle null RMP data #288

Open
1 task done
AbhiramTadepalli opened this issue Oct 29, 2024 · 0 comments · May be fixed by #292
Open
1 task done

[Bug]: LHS & RHS handle null RMP data #288

AbhiramTadepalli opened this issue Oct 29, 2024 · 0 comments · May be fixed by #292
Assignees
@George-Zhang5246
Labels
Help Wanted Extra attention is needed Type: Bug Report Issues pertaining to non-security-related issues Type: User Experience Front facing feature

Comments

@AbhiramTadepalli
Copy link
Contributor

What did you expect to happen?

If there is no RMP data, it should be indicated properly (https://trends.utdnebula.com/dashboard?searchTerms=Yu+Chung+Ng)

What happened?

I get 0 as the rating (when it should be null) and -1% for would take again.
image

Same applies for the rating component, hovers on LHS, and RHS compare
image

Version

trends.utdnebula.com

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@AbhiramTadepalli AbhiramTadepalli added Type: Bug Report Issues pertaining to non-security-related issues Help Wanted Extra attention is needed Type: User Experience Front facing feature labels Oct 29, 2024
@George-Zhang5246 George-Zhang5246 self-assigned this Oct 30, 2024
@George-Zhang5246 George-Zhang5246 linked a pull request Oct 30, 2024 that will close this issue
288 bug handle null rmp data #292
Open
@George-Zhang5246 George-Zhang5246 linked a pull request Oct 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@George-Zhang5246 George-Zhang5246

Labels
Help Wanted Extra attention is needed Type: Bug Report Issues pertaining to non-security-related issues Type: User Experience Front facing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

288 bug handle null rmp data UTDNebula/utd-trends
2 participants
@George-Zhang5246 @AbhiramTadepalli