Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Professors with middle names can be hard to find in the search bar #260

Open
1 task done
TyHil opened this issue Oct 15, 2024 · 1 comment
Open
1 task done
Labels
Type: Bug Report Issues pertaining to non-security-related issues

Comments

@TyHil
Copy link
Member

TyHil commented Oct 15, 2024

What did you expect to happen?

Typing Mehra Borazjany into Trends should pull up the correct professor but as soon as you type the B, the option goes away.

What happened?

Mehra Borazjany's full name is Mehra Nouroz Borazjany and is added to the autocomplete graph from the below data:

{
  "first_name": "Mehra Nouroz",
  "last_name": "Borazjany"
}

So the graph builds like so:

Start --> Mehra Nouroz ↘
      ↘-----------------> Borazjany --> data results

When it should build like so:

Start --> Mehra -----------------↓
      ↘         ↘---> Nouroz ↘  ↓
        ↘---------------------> Borazjany --> data results

This allows typing Mehra B and bypassing Nouroz to get to the data results so you can type the name wither with or without the middle name.

This should be possible by modfiying the addProfessor function in generateAutocompleteGraph.ts to split the first name by spaces and process each name.

Version

Beta 0.1.0

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@TyHil TyHil added the Type: Bug Report Issues pertaining to non-security-related issues label Oct 15, 2024
@TyHil
Copy link
Member Author

TyHil commented Oct 15, 2024

I drew those graphs pretty poorly so lmk if I can clarify them more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Report Issues pertaining to non-security-related issues
Projects
None yet
Development

No branches or pull requests

1 participant