Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Reorganize components #250

Open
TyHil opened this issue Oct 8, 2024 · 5 comments
Open

[Internal] Reorganize components #250

TyHil opened this issue Oct 8, 2024 · 5 comments
Assignees
Labels
Type: Internal Chore tasks that are needed for other features

Comments

@TyHil
Copy link
Member

TyHil commented Oct 8, 2024

Overview of Proposed Changes

The component folder organization is outdated

Details

Currently the components are organized into 4 folders: common, graph, icons, and navigation. But there's 17 components in common and only 1-2 in each of the other folders. I'd propose a new organizational system with more/different folders. Not sure what these should be, that requires some discussion, but this change would be handy for developers.

@TyHil TyHil added the Type: Internal Chore tasks that are needed for other features label Oct 8, 2024
@George-Zhang5246
Copy link
Contributor

Maybe we could make 2 more folders, one for tables and one for info? There will still be a lot of components in the common folder though.

@sparklingwter sparklingwter self-assigned this Oct 9, 2024
@TyHil
Copy link
Member Author

TyHil commented Oct 28, 2024

@George-Zhang5246 I like that idea. To get more things out of common we can put anything table-related in the table folder too, like filters and rating.

I think we can combine the graph and icons folders too since those icons are only used in the graphs

@sparklingwter
Copy link
Contributor

Hi, i was actually in the progress of combining the icon and the graph :) happy arranging!

@TyHil
Copy link
Member Author

TyHil commented Oct 30, 2024

yay! @sparklingwter are you doing the arranging?

@sparklingwter
Copy link
Contributor

maybe...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Internal Chore tasks that are needed for other features
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants