Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit testing to api-tools #22

Open
1 task
jpahm opened this issue Jan 30, 2024 · 5 comments
Open
1 task

Add unit testing to api-tools #22

jpahm opened this issue Jan 30, 2024 · 5 comments
Labels
L3 A task suitable for someone who is comfortable implementing large-scale features/projects. Type: Feature Request New feature or request

Comments

@jpahm
Copy link
Contributor

jpahm commented Jan 30, 2024

The toolkit would greatly benefit from both unit and integration testing, and ideally sooner rather than later.

We'll have to talk about how exactly we want to go about effectively performing integration testing, but unit testing should be fairly straightforward via Go's built-in testing library. I would personally be in favor of the test files being within the same package as the files being tested so that non-exported methods can be tested more easily.

  • Create unit tests for all existing non-elementary parts of the toolkit

Any comments on this are welcome, as usual.

@jpahm jpahm added Type: Feature Request New feature or request L2 A task suitable for someone who is comfortable helping with implementing features. labels Feb 3, 2024
@TortCode
Copy link
Member

TortCode commented Mar 20, 2024

I can work on this, starting with the unit testing at least

@jpahm
Copy link
Contributor Author

jpahm commented Mar 21, 2024

Yeah, no worries on integration testing yet. You've got it!

@jpahm jpahm assigned jpahm and TortCode and unassigned jpahm Mar 21, 2024
@jpahm
Copy link
Contributor Author

jpahm commented Sep 5, 2024

@TortCode Are you still working on this?

@jpahm
Copy link
Contributor Author

jpahm commented Oct 13, 2024

Reopening this since I haven't heard any updates for a while.

@jpahm jpahm changed the title Add testing Add unit testing to api-tools Oct 13, 2024
@jpahm
Copy link
Contributor Author

jpahm commented Oct 13, 2024

*Also going to bump this up to an L3 since it's a rather large undertaking at this point

@jpahm jpahm added L3 A task suitable for someone who is comfortable implementing large-scale features/projects. and removed L2 A task suitable for someone who is comfortable helping with implementing features. labels Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L3 A task suitable for someone who is comfortable implementing large-scale features/projects. Type: Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants