Disable Tapir on Julia 1.11 #2368
Conversation
|
Since CI only tests Julia 1.7 (min version) and Julia 1.11 (latest version), this PR has the interesting effect of excluding Tapir entirely from CI. This problem should be fixed once #2341 is merged, though; and if we want to be very safe we could explicitly test 1.10 as well. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2368 +/- ##
===========================================
+ Coverage 0.00% 46.09% +46.09%
===========================================
Files 22 22
Lines 1533 1575 +42
===========================================
+ Hits 0 726 +726
+ Misses 1533 849 -684 ☔ View full report in Codecov by Sentry. |
| @@ -284,7 +284,7 @@ adbackends = [ | |||
| Turing.AutoForwardDiff(; chunksize=0), Turing.AutoReverseDiff(; compile=false) | |||
| ] | |||
|
|
|||
| # Tapir isn't supported for older Julia versions, hence the check. | |||
| # Tapir isn't supported for older Julia versions or for 1.11, hence the check. | |||
| install_tapir = isdefined(Turing, :AutoTapir) | |||
There was a problem hiding this comment.
@penelopeysm, let's replace all references to Tapir with Mooncake so we don't need to maintain this legacy testing code.
There was a problem hiding this comment.
I did that as part of #2341 😄 But (correct me if I'm wrong) as long as Mooncake is failing on 1.11, we actually need to keep this conditional import around, because Mooncake doesn't specify that it doesn't work on 1.11.
There was a problem hiding this comment.
Oh, hold on, I literally just saw that Mooncake is now fixed for 1.11 🎉 Let's see if this can be simplified.
|
Ooh please don't merge. May be superseded by #2341; I'll try to get that to pass CI today. |
Pull Request Test Coverage Report for Build 11440413334Details
💛 - Coveralls |
|
Closing in favour of #2341 as CI should pass on that PR now |
Tapir doesn't work with Julia 1.11. In fact, it will never work with 1.11, since the package has been renamed (unless Mooncake updates are backported to Tapir). This PR disables Tapir as an AD backend on Julia 1.11.