-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect @turf/intersect result with polygon holes #2230
Comments
I think that this fails at a different stage. turf-mask doesn't care about inverting the inner rings of its input, so the geometry for I think, as far as I can tell, that the bug is that turf-mask should return a MultiPolygon in this case, which would allow the "inverted" geometry to have an island: And that then works properly with turf-intersect. This hinges on whether turf-mask is really expected to "invert" features, or whether it's just masking the outer ring. I don't have a preference or leaning there. Demo: https://observablehq.com/d/f74ec973c66b1940 (there's a checkbox in there to toggle whether to use a multipolygon) |
I've added a PR #2346 that adds support for holes to |
@turf/intersect version: 6.5.0
@turf/mask version: 6.5.0
@turf/helpers version: 6.5.0
Intersect does not produce a correct result when a polygon contains a hole, that hole contains an island, and the polygon to be intersected intersects that island. The part intersecting the island is ignored in the output.
As a simple example, here we create a large square with a small square hole in the middle, and use turf mask to invert it, then intersect that resulting mask with another large square of the same dimensions but without the hole. In this example, result is null, when in fact it should be a polygon with the same dimensions as the small square:
The text was updated successfully, but these errors were encountered: