Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of customAction configuration #2272

Open
gskrobisz opened this issue Sep 27, 2021 · 1 comment
Open

Refactoring of customAction configuration #2272

gskrobisz opened this issue Sep 27, 2021 · 1 comment

Comments

@gskrobisz
Copy link
Member

💥 Proposal

While implementing customActions I've encountered several issues and it would be nice to discuss how to approach them:

  1. There is an inconsistency in the configuration of custom-action (definition and implementation provided via DeploymentManager) and custom-link (configuration only).
  2. A customAction seems to be available only in top-right section of Nussknacker frontend ("process-info-panel").
  3. I can define an editor for CustomActionParameter, but not validator.
  4. DTO's used to invoke customAction are spread through different modules. Those used for deployment are in nussknacker-restmodel, and customAction is currently in nussknacker-ui.
  5. What is recommended approach to provide custom definition of invokeCustomAction in PeriodicDeploymentManager?
    Some elements that are usefull for invokeCustomAction exist only in PeriodicDeploymentManager.apply and are not accesible from within class.
  6. What is recommended approach to call other NK services from within PeriodicDeploymentManager?
    E.g. invoke addComment (ProcessActivityRepository).
  7. Method PeriodicDeploymentManager.apply seems to be too long.
@jedrz
Copy link
Contributor

jedrz commented Jan 11, 2022

What's more the following features would be useful too:

  • Allow to configure permissions to invoke the custom action.
  • Allow to configure where the button should be displayed (position and panel). Integrate with processToolbarConfig.
  • Allow to hide completely the custom action button. Logic to hide/show and disable/enable the button should depend on scenario json (e.g. show the button only if the scenario uses some components and enable the button only in some statuses of the scenario).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants