Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash on startup with spell engine mod #46

Open
AnukWarrior opened this issue Sep 11, 2024 · 2 comments
Open

crash on startup with spell engine mod #46

AnukWarrior opened this issue Sep 11, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@AnukWarrior
Copy link

AnukWarrior commented Sep 11, 2024

Describe the bug
attempting to launch minecraft with spell engine and ryoamiclights crashes the game on startup

To Reproduce
Steps to reproduce the behavior:
1.install ryoamiclights and its dependancys
2.install spell engine and its dependancys
3.start up minecraft
4.game crashes during boot

Expected behavior
starting up minecraft with spell engine and ryoamiclights with no crash

Desktop (please complete the following information):

  • OS: [windows 11]
  • Minecraft [1.21.1]
  • Fabric Loader version [0.16.5]
  • Mods
    [
    fabric-api-0.104.0+1.21.1
    RyoamicLights-fabric-0.2.11+mc1.21.1
    ObsidianUI-fabric-0.2.7+mc1.21
    cloth-config-15.0.130-fabric
    player-animation-lib-fabric-2.0.0-alpha1+1.21
    spell_power-1.0.4+1.21.1
    spell_engine-1.0.4+1.21.1
    trinkets-3.10.0
    ]

Additional context

i tested this on prism launcher by the way

spell engine link

https://modrinth.com/mod/spell-engine

logs

crash-2024-09-11_13.25.45-client.txt

latest.log

@AnukWarrior AnukWarrior added the bug Something isn't working label Sep 11, 2024
@NattoRiisa
Copy link

same bug happening on my end too

@ZsoltMolnarrr
Copy link

The implementation of this distribution is incorrect.

It uses the old entrypoint, defined by of LambDynamicLights, for example:

    "dynamiclights": [
      "net.spell_engine.client.compatibility.DynamicLightsCompatibility"
    ]

while expecting new package names to be used.

Old package names were:

import dev.lambdaurora.lambdynlights.api.DynamicLightHandlers;
import dev.lambdaurora.lambdynlights.api.DynamicLightsInitializer;

To handle breaking changes in a more compatible manner, it is strongly recommended for this project to rename its entrypoint, to something unique. (such as ryoamic_dynamic_lights)

The current state of this project makes it impossible to support both LambDynamicLights and SodiumDynamicLights and /
RyoamicLights, forcing the code to choose. While all of these being available simultaneously for players to download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants