Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RyoamicLights 0.2.10 config not being overwritten properly #41

Closed
NovaViper opened this issue Aug 19, 2024 · 3 comments
Closed

RyoamicLights 0.2.10 config not being overwritten properly #41

NovaViper opened this issue Aug 19, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@NovaViper
Copy link

Describe the bug
So after updating the initial crashing that was present in #38 is gone, but only after the first launch (and me not touching the configuration at all). As soon as I open the in-game config menu for the mod; it creates a duplicate [light_sources] entry; which is exactly the bug that's causing #40 for fabric users (and in my case, also affects NeoForge!).

To Reproduce
Steps to reproduce the behavior:

  1. Launch Minecraft (make sure that the config for RyoamicLights doesn't exist first, the normal config with just the light_sources entry is created)
  2. Go to 'Mods' in the game menu
  3. Click on 'RyoamicLights' and open its mod configuration menu (editing any values is not necessary)
  4. Close the game immediately
  5. Relaunch the game
  6. Crash occurs

Expected behavior
Opening the mod's configuration menu should not result in a duplicate light_sources entry, it should completely clear the file first and then add in the new configurations

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Linux 6.9.9-xanmod1, NixOS, 24.11 (Vicuna), 24.11.20240719.a069165
  • Minecraft 1.21
  • NeoForge version 0.2.10+mc1.21.1
  • Mods [client-1.21-20240613.152323-srg.jar, RyoamicLights-neoforge-0.2.10+mc1.21.1.jar,ObsidianUI-neoforge-0.2.7+mc1.21.jar,neoforge-21.0.148-universal.jar]
  • Version 0.2.10
  • Branch [mc1.21.x]

Additional context
Add any other context about the problem here.

@NovaViper NovaViper added the bug Something isn't working label Aug 19, 2024
@TexBlock
Copy link
Member

fixed in 0.2.11

@leon0399
Copy link

Btw it still crashes on 0.2.11, until I deleted config file

@TexBlock
Copy link
Member

Btw it still crashes on 0.2.11, until I deleted config file

You need to delete the old configuration first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants