Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotuner: Make flow variable detection more robust #2401

Open
maliberty opened this issue Sep 30, 2024 · 0 comments · May be fixed by #2452
Open

Autotuner: Make flow variable detection more robust #2401

maliberty opened this issue Sep 30, 2024 · 0 comments · May be fixed by #2452
Assignees
Labels
autotuner Flow autotuner

Comments

@maliberty
Copy link
Member

Subject

[Stage]: Other. Please describe below.

Describe the bug

In #2397 the check

            if key not in flow_variables:
                print(f"[ERROR TUN-0017] Variable {key} is not tunable.")
                sys.exit(1)

was disabled due to robustness issues.

Expected Behavior

Do not try to parse the tcl files directly and use a more generic mechanism to get the flow variables. #2393 might be relevant.

Environment

As above.

To Reproduce

Use the latest ORFS with the commented section of code re-enabled.

Relevant log output

No response

Screenshots

No response

Additional Context

No response

@maliberty maliberty added the autotuner Flow autotuner label Sep 30, 2024
@luarss luarss linked a pull request Oct 12, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autotuner Flow autotuner
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants