ClientToServerDisruptor NPE when using a Dynamic Config

[aurbroszniowski]

When using a Dynamic config, the Tsa.licenseAll() method (which updates the Tsa ports with proxied ports in case of a using a disruption controller) is never called.
Therefore the Tsa is not updated with proxied ports, and the disruption controller instance gives a NPE
See this failing test:

  public void testReconnectFailureHandling() throws Exception {
    ConfigurationContext configContext = customConfigurationContext()
        .tsa(tsa -> tsa
            .topology(
                new Topology(
                    distribution(version(VERSION), PackageType.KIT, LicenseType.TERRACOTTA),
                    true,
                    dynamicCluster(
                        stripe(
                            server("Server1", "localhost")
                                .tsaPort(9517)
                                .tsaGroupPort(9537)
                                .configRepo("terracotta1/repository")
                                .logs("logs1")
                                .metaData("terracotta1/metadata")
                                .failoverPriority("availability")
                        )
                    )
                )
            ).license(new License(getLicenseURL()))
        );

    try (ClusterFactory factory = new ClusterFactory("testReconnectFailureHandling", configContext)) {
      Tsa tsa = factory.tsa();
      tsa.startAll();
      tsa.attachAll();
      tsa.activateAll();

      final ClientToServerDisruptor disruptor = tsa.disruptionController().newClientToServerDisruptor();
      final URI terracottaServerURI = disruptor.uri();

    }
  }

[saurabhagas]

Moving it to @mobasherul as he's worked on the disruption part.

[mobasherul]

I used to call tsa.updateToProxiedPorts explicitly in test and use those ports to change public host ports to test client to server disruption in Dynamic cluster. Something like -
Tsa tsa = factory.tsa().startAll().activateAll();
Map<ServerSymbolicName, Integer> proxyTsaPorts = tsa.updateToProxiedPorts();
TerracottaServer terracottaServer = tsa.getActive();
int proxyPort = proxyTsaPorts.get(terracottaServer.getServerSymbolicName());
ConfigToolExecutionResult result = tsa.configTool(terracottaServer).executeCommand("set", "-s", "localhost:" + terracottaServer.getTsaPort(),
"-c", "stripe.1.node.1.node-public-hostname=localhost", "-c", "stripe.1.node.1.node-public-port=" + proxyPort);