-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve testing of Open graph to pattern conversions #196
Comments
How are you planning to generate the open-graphs ? |
Great question. I do not know. Open graphs need four items, a graph, measurements for non-output nodes, inputs and outputs. All of these could be randomised however it is very likely the resulting open graph would not have flow. We could simply repeat the procedure enough times, checking each time whether the open graph has flow and then stop when we find one. It is not very efficient but it is simple. Another way would be to randomly generate circuits in PyZX, then convert those to a graph using PyZX's in-built |
Currently we only test converting Open graphs to (
OpenGraph.to_pattern()
) and from (OpenGraph.from_pattern()
) patterns with a couple of handcrafted examples intests/test_opengraph.py
.It would instead be more robust to test these methods on many randomly generated graphs and patterns (by modifying
random_objects.py
with random open graph generation), and check the results against a simulator.The text was updated successfully, but these errors were encountered: