Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pauli planes to measurement-plane data structure #181

Open
shinich1 opened this issue Jul 25, 2024 · 1 comment
Open

Add Pauli planes to measurement-plane data structure #181

shinich1 opened this issue Jul 25, 2024 · 1 comment
Labels
new feature New feature or request

Comments

@shinich1
Copy link
Contributor

Currently, Pauli measurements are determined by checking the angle mod $2\pi$, with non-zero possiblity of incorrect determination of Pauli-measured nodes by numerical errors. I believe it's natural to incorporate Pauli measurements as X, Y, and Z planes. See also implementation of rust-based flow-finding routines in TeamGraphix/fastflow#3.

@shinich1 shinich1 added the new feature New feature or request label Jul 25, 2024
@shinich1 shinich1 changed the title Add Pauli plane measurements Add Pauli planes to measurement-plane data structure Jul 25, 2024
@mgarnier59
Copy link
Contributor

Indeed that's something we were considering when looking at upgrading the Pauli measurement preprocessing.
Are we sure, the modulo can miss some cases? I had the same question but it seemed to work well so we decided it wasn't necessary.

If we add this we then have multiple ways of defining Pauli measurement that will have to be delt with.

No strong opinion about this, open to discussion !

thierry-martinez added a commit to thierry-martinez/graphix that referenced this issue Jul 28, 2024
This commit introduces a new method `is_pauli` on `M` commands, which
returns a pair `(axis, sign)` if the measure is Pauli, and `None`
otherwise.

This method takes an optional parameter `precision`
($\rho$, default: `1e-6`):
a measure is considered to be Pauli if the angle is in an interval
$[- \rho + k \cdot \frac \pi 2; \rho + k \cdot \frac \pi 2]$,
addressing the precision problem raised in TeamGraphix#181.

`axis` is computed by using the `cos` and `sin` definitions of
`pauli.py`, solving the inconsistency bug reported in TeamGraphix#188.

This commit introduces a new `Sign` class to make code manipulating
`Plus` and `Minus` to be more readable than when using `bool`.
thierry-martinez added a commit to thierry-martinez/graphix that referenced this issue Jul 28, 2024
This commit introduces a new method `is_pauli` on `M` commands, which
returns a pair `(axis, sign)` if the measure is Pauli, and `None`
otherwise.

This method takes an optional parameter `precision`
($\rho$, default: `1e-6`):
a measure is considered to be Pauli if the angle is in an interval
$[- \rho + k \cdot \frac \pi 2; \rho + k \cdot \frac \pi 2]$,
addressing the precision problem raised in TeamGraphix#181.

`axis` is computed by using the `cos` and `sin` definitions of
`pauli.py`, solving the inconsistency bug reported in TeamGraphix#188.

This commit introduces a new `Sign` class to make code manipulating
`Plus` and `Minus` to be more readable than when using `bool`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants