Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styling of new attr lists #657

Open
sydb opened this issue Jan 11, 2024 · 1 comment · May be fixed by #682
Open

styling of new attr lists #657

sydb opened this issue Jan 11, 2024 · 1 comment · May be fixed by #682
Assignees
Labels
conversion: html priority: high Relatively urgent; Council should revisit routinely.

Comments

@sydb
Copy link
Member

sydb commented Jan 11, 2024

We recently changed the listing of attributes on tagdoc pages to use actual <ul> and <li> elements, and gave them CSS so that they look much better than they used to. And this seems to work fine in the Guidelines HTML output, but in a customization ODD (e.g., generated by bin/teitohtml --odd) the new list is missing the colon and space between the class name and the first attribute.

I think this may be because the CSS file used for custom documentation (https://www.tei-c.org/release/xml/tei/stylesheet/tei.css) does not have a rule for "ul.classSpecAttDefs". But I am not sure whether the rules from this repo (in P5/odd.css) or from the Styleseets repo (in css/odd.css), if either, should be used. (Actually, those specific rules may be the same, even though the files are moderately different. But in any case, those rules apply to ul.attList a.link_odd + ul.classSpecAttDefs::before, but the custom documentation HTML has class="link_ref" where the Guidelines have class="link_odd", I think.

@sydb sydb added this to the Release 7.57.0 milestone Jan 11, 2024
@joeytakeda joeytakeda added conversion: html priority: high Relatively urgent; Council should revisit routinely. labels Feb 3, 2024
joeytakeda added a commit that referenced this issue May 6, 2024
Adds another rule to odd.css to ensure colon and space
@joeytakeda
Copy link
Contributor

It looks like the rules in Stylesheets/css/odd.css are imported into tei.css; not sure why this is a link_ref and not a link_odd, but I've now added another rule in odd.css

@joeytakeda joeytakeda linked a pull request May 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conversion: html priority: high Relatively urgent; Council should revisit routinely.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants