-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stereo offset for legacy data #580
Comments
Following up on this, at least one control program (cpid = 4204, from 1998-2009) used the
although FITACF 3.0 appears to be unaffected since it also compares against the channel number, eg (https://github.com/SuperDARN/rst/blob/main/codebase/superdarn/src.lib/tk/fitacf_v3.0/src/preprocessing.c#L609)
As an aside, LMFIT (v1) appears to handle this completely incorrectly (comparing against
(edit note that FITACFEX2 also uses this incorrect logic) while LMFIT v2 does not appear to treat Stereo data differently at all (at least based on either the Getting back to the early Stereo mode data, it appears the |
Also, because STO
So either these files need to be corrected, or the |
Buried deep in
fitacf.c
of FITACF 2.5 there is the following comment:which, as far as I can tell, has been present in this file / FITACF since at least 2006 (e.g., https://github.com/SuperDARN/rst-archive/blob/rst.2.05/code/src.lib/superdarn/fitacf.1.22/src/fitacf.c#L169-L171). For context, our software currently assumes the
offset
value for Stereo data indat
- andfit
-format files is stored in theusr_resL1
field.In a copy of Sessai's code, here was his explanation of this issue:
I'll try reaching out to Sessai, but my impression is that this fix needs to be implemented at a more fundamental level (ie at the I/O stage within
OldRawReadCurrent
of theoldraw
library andOldFitReadCurrent
of theoldfit
library) rather than within a later processing stage such as FITACF. And I suppose the native IDLdat
/fit
code may require modifications too...The text was updated successfully, but these errors were encountered: