Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression default should be DEFLATE, not STORE #931

Open
FuzzyGamesOn opened this issue Sep 25, 2024 · 0 comments
Open

Compression default should be DEFLATE, not STORE #931

FuzzyGamesOn opened this issue Sep 25, 2024 · 0 comments

Comments

@FuzzyGamesOn
Copy link

FuzzyGamesOn commented Sep 25, 2024

(After seeing some of the comments on other issues, seems like I'm not the only person that was confused by this.)

The default value for the compression option on generateAsync should be the value that people are most likely to use. And I feel like most users seeking out a zip library would expect that the zip would be compressed by default. So having the default be STORE (no compression) seems incorrect, and like it would just confuse users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant