Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case where PAL fails to update pogoist pos through entire game #81

Open
mpatsift opened this issue Mar 2, 2023 · 3 comments
Open

Case where PAL fails to update pogoist pos through entire game #81

mpatsift opened this issue Mar 2, 2023 · 3 comments

Comments

@mpatsift
Copy link

mpatsift commented Mar 2, 2023

One of our internal tests failed b/c although pogoist moved and broke blocks, its pos did not change in the entities list, creating apparent novelty of blocks disappearing w/o cause.

it seems PAL is failing to update the pogoist's pos in the entities list. It does not change throughout the game.
It's stuck at 68, 17, 43. Eg, at the end of the game:

"102":{"type":"EntityPogoist","name":"entity.polycraft.Pogoist.name","id":102,"pos":[68,17,43],"color":"purple","equipment":[{"itemName":"Noble Pantoble","itemMeta":0,"count":1},{"itemName":"Noble Leggings","itemMeta":0,"count":1},{"itemName":"Noble Gorget","itemMeta":0,"count":1},{"itemName":"Noble Armet","itemMeta":0,"count":1}]},

Otoh, the pogoists pos does change in the action list, eg:

"action":{"action":"BREAK_BLOCK","args":"","result":"SUCCESS","stepNumber":65,"pos":[69,17,57],"dir":"NORTH","blockInFront":{"name":"minecraft:log","axis":"y","variant":"oak"}},"entityID":102}

I'll attach pal-tournament.log and the PAL messages echoed by our bridge.

(for sift ref: ticket:442 and full logs at /var/lib/jenkins/workspace/openmind/build-images/code/test/results/pal-tournament-v2-nonov-3-games-2023-03-01-193740-openmind0)

@mpatsift
Copy link
Author

mpatsift commented Mar 2, 2023

@mpatsift
Copy link
Author

mpatsift commented Mar 8, 2023

Seen again:

In attached file (entity-list-from-bridge-log.txt), PAL reports two different locs for the pogoist:
[68,17,43] (the reported position that never changes)

"102":{"type":"EntityPogoist","name":"entity.polycraft.Pogoist.name","id":102,"pos":[68,17,43],"color":"purple","equipment":[{"itemName":"Noble Pantoble","itemMeta":0,"count":1},{"itemName":"Noble Leggings","itemMeta":0,"count":1},{"itemName":"Noble Gorget","itemMeta":0,"count":1},{"itemName":"Noble Armet","itemMeta":0,"count":1}]}

and [69,17,57] (which seems to be the actual position, where pogoist is breaking a tree):

"action":{"action":"BREAK_BLOCK","args":"","result":"SUCCESS","stepNumber":65,"pos":[69,17,57],"dir":"NORTH","blockInFront":{"name":"minecraft:log","axis":"y","variant":"oak"}},"entityID":102},

entity-list-from-bridge-log.txt
pal-tournament-v2-nonov-3-games-2023-03-07-212231-openmind0_pal-tournament.log.gz

@mpatsift
Copy link
Author

NOTE: this could cause our agent to send an erroneous novelty report (ie, FALSE POSITIVE) when pogoist's actions interfere with its plan, even though pogoist is apparently not moving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant