Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-part Websockets broken - here's a fix #36

Open
MightyPork opened this issue Jan 24, 2017 · 0 comments
Open

Multi-part Websockets broken - here's a fix #36

MightyPork opened this issue Jan 24, 2017 · 0 comments

Comments

@MightyPork
Copy link

It sends OpCode other than 0 ("CONT") in the continuation frames, which does not work (browser throws an error). This happens if you use WEBSOCK_FLAG_CONT to send multiple chained messages.

I fixed this in my fork by adding WEBSOCK_FLAG_MORE

Now: WEBSOCK_FLAG_MORE = no FIN, WEBSOCK_FLAG_CONT = opcode 0. Works perfectly!

MightyPork@1a69994

Not sure if you want a PR or not, I already have a bunch of other improvements there. But this is the first bug I found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant