"X sets SpacemanDMM_should_be_pure but calls a Y that does impure operations" happens when changing proc argument variables

[mc-oofert]

https://github.com/tgstation/tgstation/actions/runs/7408501187/job/20156828882

this is where the linter marks an issue

here is marked the impurity, where gravity_turf (proc arg) is changed

potato says the issue is failing to treat proc arguments as local to the proc
i do not know what else to add to this

[Ghommie]

PR where this happened: tgstation/tgstation#80790

[SpaceManiac]

Hmm, it seems to have originally been intentional:

SpacemanDMM/crates/dreamchecker/src/lib.rs

Line 1158 in 59cfdbf

analysis.is_impure = Some(true); // all params are impure

It'll take some investigation to be sure that changing this doesn't have side-effects.