-
-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Language appear in the drop down in preferences but doesn't work #6771
Comments
You could try raising a draft PR so I could take a better look at what you've got so far. |
The reason it doesn't work is this: OrcaSlicer/src/slic3r/GUI/GUI_App.cpp Lines 5091 to 5094 in 587e839
|
Okaaay, So it there a way to exclude Arabic from that condition, since it's working correctly? |
You can just change the line I mentioned above, (or even delete that check) |
Ah... I guess that's how wxwidgets handles right-to-left languages. |
Is there an existing issue for this problem?
OrcaSlicer Version
2.2.0
Operating System (OS)
Windows
OS Version
windows 11
Additional system information
No response
Printer
all
How to reproduce
create new language and add the mo file to i18n folder
Actual results
I followed the localization wiki page to create a new language that doesn't exist in orcaslicer, then I modified the preferences.cpp file to add add it. The Language now appears in the dropdown in preferences window but when I choose it the orcaslicer needs to be restarted as normal but after restart the language still English.
I tried to move the mo file to the en folder to test whether it works or not, and it appears correctly.
Expected results
new language should take over the UI
Project file & Debug log uploads
Checklist of files to include
Anything else?
No response
The text was updated successfully, but these errors were encountered: