Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent Gap in Timeline Display Causing Missing Hour #381

Open
sawongam opened this issue Jun 17, 2024 · 4 comments · May be fixed by #384
Open

Intermittent Gap in Timeline Display Causing Missing Hour #381

sawongam opened this issue Jun 17, 2024 · 4 comments · May be fixed by #384
Labels
waiting-for-resoponse Waiting for someone to respond.

Comments

@sawongam
Copy link

I've encountered an issue where, intermittently, there seems to be a gap in the timeline display, resulting in an hour being missing. This occurrence doesn't seem to follow a specific pattern; it happens randomly. I've tested this on multiple devices, and the issue persists across all of them. Could you please investigate this problem further?

For context, I'm using timelineBuilder in my implementation. Below is the relevant code snippet:

timelineBuilder: (time) {
  return Text(
    DateTimeUtils.formatTime(time),
    textAlign: TextAlign.center,
  );
}

Additionally, I've attached a screenshot below that illustrates the issue.

Screenshot_20240617_105631

@mayank29malhotra
Copy link

I can work on this issue : by giving the user the option to hide the current hour or not

@sawongam
Copy link
Author

I can work on this issue : by giving the user the option to hide the current hour or not

Could you please explain the cause of the issues? Additionally, could you clarify how addressing option to hide current hour will impact the code?

@mayank29malhotra
Copy link

the issue is when the current hour is 4 PM then 4PM hour text is not visible due to code segment

visible: !((_currentTime.minute >= 45 && _currentTime.hour == hour - 1) ||
(_currentTime.minute <= 15 && _currentTime.hour == hour))

in the internal Components.

So the visibility of the Hour text is calculated here here we can add a parameter if that is true the visibility should be true else it will be calculated like this, and the parameter will be false by default.

@DhavalRKansara
Copy link
Collaborator

Hi @sawongam,

Thanks for reporting the issue. I couldn't replicate the problem when running the code from the latest commit on the master branch. Could you please check from your end using the master branch and let us know if the issue persists?

@mayank29malhotra, your contribution here would be appreciated as well.

Thank you!

@DhavalRKansara DhavalRKansara added the waiting-for-resoponse Waiting for someone to respond. label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-resoponse Waiting for someone to respond.
Projects
None yet
3 participants