Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TimeOfDay instead of DateTime for start and end time in CalendarEventData. #293

Open
PRBaraiya opened this issue Nov 23, 2023 · 1 comment
Labels
enhancement New feature or request priority:5 This label defines Bug/Enhancement with lowest priority.

Comments

@PRBaraiya
Copy link
Collaborator

In the current CalendarEventData model, we are using the object of DateTime to define the start and end time of an event. But while manipulating the event, we are only using hours and minutes from the DateTime so, it is getting confusing. Because Users have to provide the date information even though it's not being used.

So, one solution that we can implement is to use TimeOfDay to store the start and end times.

We can deprecate some variables, that define the time span of an event and move it to a separate model. And in the next major version, we can completely remove it.

@PRBaraiya PRBaraiya changed the title User TimeOfDay instead of DateTime for start and end time in CalendarEventData. Use TimeOfDay instead of DateTime for start and end time in CalendarEventData. Nov 23, 2023
@PRBaraiya PRBaraiya added enhancement New feature or request priority:1 Bug/Enhancement with highest priority. labels Nov 23, 2023
@ParthBaraiya ParthBaraiya added priority:5 This label defines Bug/Enhancement with lowest priority. and removed priority:1 Bug/Enhancement with highest priority. labels Feb 21, 2024
@mayank29malhotra
Copy link

I can work on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:5 This label defines Bug/Enhancement with lowest priority.
Projects
None yet
Development

No branches or pull requests

3 participants