Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for < in sentences causes skipping of valid VDM sentences #94

Open
sbender9 opened this issue Oct 5, 2017 · 3 comments
Open

Check for < in sentences causes skipping of valid VDM sentences #94

sbender9 opened this issue Oct 5, 2017 · 3 comments

Comments

@sbender9
Copy link
Member

sbender9 commented Oct 5, 2017

The check in parse.js:

  // The (MTK) CRC check doesn't report "invalid" if the input string contains the "<" character, even though it actually isn't valid.
  if (sentence.includes('<')) {
    valid = false
  }

I see some VDM messages that contain this but parse fine if I remove the check, For example: !AIVDM,1,1,,A,352JPU@000JRU4<FCLvaEWOp0000,0*1B

@joabakk
Copy link
Contributor

joabakk commented Oct 5, 2017

Ok, it should not apply to ais sentences. The problem is that that character does not count in the checksum, so it was a way to ignore some corrupted sentences in the test files.

@joabakk
Copy link
Contributor

joabakk commented Oct 5, 2017

@fabdrol?

@joabakk
Copy link
Contributor

joabakk commented Oct 5, 2017

I ran the offending test file again without the condition, and it works fine. I guess it's a fix no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants