-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Charts API/plugin does not allow multiple providers #31
Comments
That is absolutely correct. We really should change the resources/charts api to work like the rest of the resources v2 api: there can be multiple providers for the same resource type. @panaaj any thoughts? My hunch is that it should be pretty straightforward. I could get around to doing that during this winter, unless somebody beats me to it. Do we need anything on the server side, or is it just changing the plugin? Will the multiple providers mechanism be available only in the v2 api? |
It does / should support multiple providers on the V2 endpoint (as this leverages the resources API). For v1 endpoints to support multiple providers it will need both server and plugin. My question would be why? Shouldn't we be looking ahead and encouraging the move to V2? |
I think that until you have completely banned API v.1, you should require a plugin to comply with all the rules of API v.1. |
This is a separate issue to supporting multiple providers. Fixing this is likely to be a breaking change for clients. So if we require clients to be updated, that effort should be to support V2 not a breaking change to v1. |
The plugin does not support Server API for plugins.
So, there is no way to make another server plugin use same
/signalk/v1/api/resources/charts/
path.The text was updated successfully, but these errors were encountered: